Bug 24679

Summary:

fast/events/standalone-image-drag-to-editable.html fails on windows due to local access checks

Product:

WebKit

Reporter:

Tony Chang <tony>

Component:

Tools / Tests

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
[1/1] use a local file for the iframe rather than a data url	ap: review+

Tony Chang

Reported 2009-03-18 13:35:07 PDT

The test standalone-image-drag-to-editable.html has an iframe that is a data: url. It tries to drag an image from a file: url into the iframe. Since by default local loads are disabled, the image fails to load in the data url. Since this test has nothing to do with local load checks, we should just use a file: url for the iframe.

Attachments
[1/1] use a local file for the iframe rather than a data url (2.51 KB, patch) 2009-03-18 13:36 PDT, Tony Chang	ap: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tony Chang

Comment 1 2009-03-18 13:36:51 PDT

Created attachment 28730 [details] [1/1] use a local file for the iframe rather than a data url LayoutTests/ChangeLog | 16 ++++++++++++++++ .../standalone-image-drag-to-editable-frame.html | 4 ++++ .../events/standalone-image-drag-to-editable.html | 5 +---- 3 files changed, 21 insertions(+), 4 deletions(-)

Alexey Proskuryakov

Comment 2 2009-03-19 01:46:37 PDT

Comment on attachment 28730 [details] [1/1] use a local file for the iframe rather than a data url r=me Another way to fix this is by using a javascript:'' URL instead of data: one, as javascript ones share security context with the opener.

David Levin

Comment 3 2009-03-20 16:03:52 PDT

In the future, please add a link to the bug in the changelog. Assigned to levin for landing.

David Levin

Comment 4 2009-03-20 16:58:19 PDT

Committed as r41883.

Note You need to log in before you can comment on or make changes to this bug.