Bug 24677 – REGRESSION: Range#surroundContents is inserting empty text nodes into the document

• Component: DOM
• Status: RESOLVED DUPLICATE

[Nick Santos]

Repro steps:
1) Create a range over the text "---[ANCHOR]Text to <br/> split[FOCUS]---"
2) Call range.surroundContents(someElement)

Results:
A 0-length text node is inserted after [FOCUS]
This is happening in 528 and 530 on Windows.

You can visit
http://www.nick-santos.com/tests/webkit_range_test.html
for a simple test case.

I don't make very good cookies, but Julie says that she will award a cookie to the person that fixes this.

[Julie Parent]

This is definitely a regression, the test passes fine in Chrome 1.0/WebKit 525.

[Alexey Proskuryakov]

Confirmed as a regression.

[Alexey Proskuryakov]

Created attachment 28760 [details]
further reduced test case

This version works in Firefox, too. The problem is actually in Range.insertNode, which surroundContents uses internally.

[Alexey Proskuryakov]

Err, not quite - it's the range start that's different after extractContents(). It used to be ([object HTMLDivElement], 1), but now it's ([object Text], 3), so insertNode is arguably correct to split the node.

[Alexey Proskuryakov]

I've got a patch that fixes this and bug 24122, which was filed earlier.

[Alexey Proskuryakov]

Oops, I meant to resolve as duplicate.

[Alexey Proskuryakov]

*** This bug has been marked as a duplicate of 24122 ***