Bug 246735

Summary:	Don't unnecessarily tear down top layer renderers in RenderTreeUpdater
Product:	WebKit	Reporter:	Tim Nguyen (:ntim) <ntim>
Component:	Layout and Rendering	Assignee:	Tim Nguyen (:ntim) <ntim>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Tim Nguyen (:ntim)

Reported 2022-10-18 23:10:07 PDT

The only reason the element.isInTopLayer() check added by https://commits.webkit.org/246767@main is there is because entering top layer forces `display: contents` style to `display: block`. This check is now redundant with https://commits.webkit.org/255527@main, since it is fixing the same issue more globally. Test: fast/css/top-layer-display-contents-crash.html

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-10-18 23:11:09 PDT

<rdar://problem/101324926>

Tim Nguyen (:ntim)

Comment 2 2022-10-18 23:12:53 PDT

Pull Request: https://github.com/WebKit/WebKit/pull/5529

EWS

Comment 3 2022-10-19 08:15:20 PDT

Committed 255733@main (394f41a9f855): <https://commits.webkit.org/255733@main> Reviewed commits have been landed. Closing PR #5529 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.