Bug 24672

Summary:

ASSERTION FAILURE: !m_purgeableData in WebCore::CachedResource::data() saving a WebArchive

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

WebCore Misc.

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

koivisto, zwarich

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

URL:

http://www.mingpaonews.com/20090318/gba1.htm

Attachments:

Description	Flags
patch	mitz: review+

David Kilzer (:ddkilzer)

Reported 2009-03-18 07:57:19 PDT

* SUMMARY When saving a WebArchive of some pages with a Debug build of WebKit, an assertion failure occurs. Noted in Bug 22931 Comment #4. * STEPS TO REPRODUCE 1. Launch Debug build of WebKit. 2. Open URL: <http://www.mingpaonews.com/20090318/gba1.htm> 3. Save As...WebArchive. * RESULTS Crash due to assertion failure. * REGRESSION This is a regression from builds of WebKit before the cache was purgeable. * NOTES Console output of crash: ERROR: Failed to archive subresource for http://www.mingpaonews.com/image/jflow_normal.gif (/Volumes/Data/WebKit.git/WebCore/loader/archive/cf/LegacyWebArchive.cpp:545 static WTF::PassRefPtr<WebCore::LegacyWebArchive> WebCore::LegacyWebArchive::create(const WebCore::String&, WebCore::Frame*, WTF::Vector<WebCore::Node*, 0ul>&)) ERROR: Failed to archive subresource for http://www.mingpaonews.com/image/jflow_selected.gif (/Volumes/Data/WebKit.git/WebCore/loader/archive/cf/LegacyWebArchive.cpp:545 static WTF::PassRefPtr<WebCore::LegacyWebArchive> WebCore::LegacyWebArchive::create(const WebCore::String&, WebCore::Frame*, WTF::Vector<WebCore::Node*, 0ul>&)) ERROR: Failed to archive subresource for http://www.mingpaonews.com/image/jflow_multibox_bkg_460.jpg (/Volumes/Data/WebKit.git/WebCore/loader/archive/cf/LegacyWebArchive.cpp:545 static WTF::PassRefPtr<WebCore::LegacyWebArchive> WebCore::LegacyWebArchive::create(const WebCore::String&, WebCore::Frame*, WTF::Vector<WebCore::Node*, 0ul>&)) ASSERTION FAILED: !m_purgeableData (/Volumes/Data/WebKit.git/WebCore/loader/CachedResource.h:137 WebCore::SharedBuffer* WebCore::CachedResource::data() const)

Attachments
patch (3.39 KB, patch) 2009-03-29 17:17 PDT, Darin Adler	mitz: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2009-03-18 07:57:43 PDT

<rdar://problem/6574263>

Cameron Zwarich (cpst)

Comment 2 2009-03-19 01:12:58 PDT

I know how to fix this.

Cameron Zwarich (cpst)

Comment 3 2009-03-29 15:54:59 PDT

The fix should really be doing something along these lines, except for WebCore::LegacyWebArchive::create(): http://trac.webkit.org/changeset/39517 Unfortunately, this can't just be done where cachedResource->data() is used, because an earlier call to DocumentLoader::subresource() also uses the cached resource's data. The right thing to do is probably to make DocumentLoader::subResource() do something along the lines of r39517, but I wanted to ask somebody who knows the code. I'll unassign this in case someone else wants to take a stab at it.

Darin Adler

Comment 4 2009-03-29 17:17:33 PDT

Created attachment 29051 [details] patch

Darin Adler

Comment 5 2009-03-29 18:59:53 PDT

http://trac.webkit.org/changeset/42095

David Kilzer (:ddkilzer)

Comment 6 2009-03-29 19:43:35 PDT

Comment on attachment 29051 [details] patch >+ I couldn't create a test case for this. In fact, the case in the bug doesn't exist any more, >+ but there is an Apple-internal website I was able to use to reproduce and fix. Any news story on the mingpaonews.com site reproduces this issue.

Note You need to log in before you can comment on or make changes to this bug.