Bug 246692 – REGRESSION: [bugs.webkit.org] Linkified commit identifiers don't go to specific commit

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Ryan Haddad]

Linkified commit identifiers in bugzilla (e.g. 255564@main) don't direct you to a page like https://commits.webkit.org/255564@main, but rather https://github.com/WebKit/WebKit/commits

Unsure if this was caused by https://commits.webkit.org/255564@main, it definitely started recently.

[Radar WebKit Bug Importer]

<rdar://problem/101297471>

[[e-mail]]

Displayed text link uses matched group 1 while generate link uses matched group 2 due to another regex handing trac.webkit.org link.

sub _replace_reference {
    my $args = shift;
    my $text = $args->{matches}->[0];
    my $reference = $args->{matches}->[1];
    return qq{<a href="https://commits.webkit.org/$reference">$text</a>};
};

My last patch left out a parentesis pair causing group 2 to be NULL.

[[e-mail]]

Pull request: https://github.com/WebKit/WebKit/pull/5349

[[e-mail]]

Pull request: https://github.com/WebKit/WebKit/pull/5500

[EWS]

Committed 255732@main (3f0b2fe64691): <https://commits.webkit.org/255732@main>

Reviewed commits have been landed. Closing PR #5500 and removing active labels.