Bug 246634
| Summary: | AudioSourceProviderAVFObjC::m_client should be Weak | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> |
| Component: | Media | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jer Noble
AudioSourceProviderAVFObjC::m_client should be Weak
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Jer Noble
<rdar://problem/100804084>
Jer Noble
Pull request: https://github.com/WebKit/WebKit/pull/5446
EWS
Committed 255745@main (9290cdbf360c): <https://commits.webkit.org/255745@main>
Reviewed commits have been landed. Closing PR #5446 and removing active labels.
Michael Catanzaro
This introduced a bug in a debug print:
[1072/2475] Building CXX object Source/WebCore/CMakeFiles...atform/audio/gstreamer/AudioSourceProviderGStreamer.cpp.o
In file included from /usr/include/gstreamer-1.0/gst/gst.h:55,
from /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h:24,
from /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h:25,
from /home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:20:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp: In member function ‘virtual void WebCore::AudioSourceProviderGStreamer::setClient(WTF::WeakPtr<WebCore::AudioSourceProviderClient>&&)’:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:257:40: warning: format ‘%p’ expects argument of type ‘void*’, but argument 8 has type ‘WTF::WeakPtr<WebCore::AudioSourceProviderClient>’ [-Wformat=]
257 | GST_DEBUG_OBJECT(m_pipeline.get(), "Setting up client %p (previous: %p)", newClient, client());
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:257:60: note: format string is defined here
257 | GST_DEBUG_OBJECT(m_pipeline.get(), "Setting up client %p (previous: %p)", newClient, client());
| ~^
| |
| void*
I will submit a follow-up.
Michael Catanzaro
Re-opening for pull request https://github.com/WebKit/WebKit/pull/5553
EWS
Committed 255761@main (e54634760b76): <https://commits.webkit.org/255761@main>
Reviewed commits have been landed. Closing PR #5553 and removing active labels.