Bug 246568
| Summary: | There is some 'captial' typo in the source tree | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | addr2line |
| Component: | New Bugs | Assignee: | Aditya Keerthi <akeerthi> |
| Status: | RESOLVED FIXED | ||
| Severity: | Trivial | CC: | ntim, webkit-bug-importer |
| Priority: | P2 | Keywords: | GoodFirstBug, InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
addr2line
There is some 'captial' typo in the source tree.
To reproduce:
$ rg 'captial' .
./Websites/browserbench.org/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js
1964: paths (i.e. a path beginning with a captial letter not defined on the
./Tools/Scripts/webkitpy/style/checkers/cpp.py
233: # Next add underscores when you have a captial letter which is followed by a capital letter
./LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/the-stylepropertymap/properties/text-transform.html
18: { syntax: 'captialize' },
./Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
3590: if (focusedElement->document().quirks().shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreas() && isTransparentOrFullyClipped(*focusedElement)) {
./Source/WebCore/page/Quirks.h
91: WEBCORE_EXPORT bool shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreas() const;
./Source/WebCore/page/Quirks.cpp
340:static bool shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreasForHost(StringView host)
396:bool Quirks::shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreas() const
401: return shouldSuppressAutocorrectionAndAutocaptializationInHiddenEditableAreasForHost(m_document->topDocument().url().host());
As far as I can tell, this is a typo.
version: commit 674e736be80335b302b90e9ea7316a8a7da191a1
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
addr2line
I want to fix the typo, but I'm not sure what is the right way to submit the patch. Make a pull request on github or just submit the patch file in the `Attachments`?
Tim Nguyen (:ntim)
(In reply to addr2line from comment #1)
> I want to fix the typo, but I'm not sure what is the right way to submit the
> patch. Make a pull request on github or just submit the patch file in the
> `Attachments`?
https://webkit.org/contributing-code/ has all the instructions to submit a Github PR. In your case you can skip step 4.
Radar WebKit Bug Importer
<rdar://problem/101455951>
Aditya Keerthi
Pull request: https://github.com/WebKit/WebKit/pull/6326
EWS
Committed 256518@main (c4dbc0c634fc): <https://commits.webkit.org/256518@main>
Reviewed commits have been landed. Closing PR #6326 and removing active labels.