Bug 246520
| Summary: | [libpas] libpas is unconditionally built with -Werror | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | bmalloc | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, ggaren, mcatanzaro, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
Michael Catanzaro
Currently libpas is built with -Werror. This is not OK because it's used unconditionally, so it's enabled in release tarballs. This has been considered bad practice for a very long time because it's likely to cause spurious build failures for anyone not using the exact same compiler version tested by the developers.
It's OK to use -Werror, but only an opt-in basis. We need to make sure it gets enabled only for developers and never for normal builds. We already have a DEVELOPER_MODE_FATAL_WARNINGS flag for this purpose, but it only works for stuff that uses WEBKIT_FRAMEWORK, WEBKIT_EXECUTABLE, or WEBKIT_WRAP_EXECUTABLE, and it looks like libpas does not use any of that. I guess libpas is avoiding use of WebKit macros in case we want to split it out from WebKit's source tree in the future, so that it can be used by other projects? If so, I suppose we cannot look at DEVELOPER_MODE_FATAL_WARNINGS. Adding a libpas-specific flag to opt-in to fatal warnings separate from DEVELOPER_MODE_FATAL_WARNINGS doesn't sound very appealing to me, but it's an option. For now, I will just remove -Werror to get us into a reasonable state. libpas maintainers can decide their preference for else to enable fatal warnings. Just setting CXXFLAGS=-Werror seems entirely reasonable to me, though. ;)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
libpas also uses -Wall, so in addition to existing warnings getting stricter, there will also be completely new warnings in the future that will break the build, which we cannot anticipate today.
Michael Catanzaro
Pull request: https://github.com/WebKit/WebKit/pull/5375
EWS
Committed 255548@main (0d78e3342b26): <https://commits.webkit.org/255548@main>
Reviewed commits have been landed. Closing PR #5375 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/101184428>