Bug 246481 – Safari crashes on https://knowyourmeme.com/memes/oh-the-huge-manatee

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

<rdar://100914598>

[alan]

Created attachment 462971 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 462971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462971&action=review

I don't have anything of substance to say, but I had comments about ChangeLog.

> COMMIT_MESSAGE:2
> +Safari crashes on 
> +https://knowyourmeme.com/memes/oh-the-huge-manatee

This should be one line.

> COMMIT_MESSAGE:8
> +This patch enables style update on the layout boxes when the renderer is floating/out-of-flow. It ensures that the layout box and the associated render stay in sync. (out of sync style could lead to an unexpected state where IFC integration layer (incorrectly) assumes that the renderer tree has certain properties (e.g. layer)).

This should probably be many lines.

[alan]

Created attachment 462975 [details]
[fast-cq]Patch

[alan]

(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 462971 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462971&action=review
> 
> I don't have anything of substance to say, but I had comments about
> ChangeLog.
> 
> > COMMIT_MESSAGE:2
> > +Safari crashes on 
> > +https://knowyourmeme.com/memes/oh-the-huge-manatee
> 
> This should be one line.
> 
> > COMMIT_MESSAGE:8
> > +This patch enables style update on the layout boxes when the renderer is floating/out-of-flow. It ensures that the layout box and the associated render stay in sync. (out of sync style could lead to an unexpected state where IFC integration layer (incorrectly) assumes that the renderer tree has certain properties (e.g. layer)).
> 
> This should probably be many lines.
Thank you.

[EWS]

Committed 255531@main (f9f41e5b4d58): <https://commits.webkit.org/255531@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462975 [details].