Bug 246450

Summary: Tear down child renderers when removing display: contents
Product: WebKit Reporter: Rob Buis <rbuis>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, glenn, kangil.han, kondapallykalyan, pdr, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 15   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2022-10-13 03:05:47 PDT
Detect when we transition away from display: contents when resolving computed styles and tear down child renderers in that case. To keep track of when to do this add a flag to Element.
Attachments
Patch (4.31 KB, patch)
2022-10-13 03:07 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (4.49 KB, patch)
2022-10-13 04:33 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (4.51 KB, patch)
2022-10-14 01:47 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2022-10-13 03:07:17 PDT
Created attachment 462955 [details] Patch
Rob Buis
Comment 2 2022-10-13 04:33:05 PDT
Created attachment 462958 [details] Patch
Rob Buis
Comment 3 2022-10-14 01:47:08 PDT
Created attachment 462983 [details] Patch
EWS
Comment 4 2022-10-14 03:49:30 PDT
Committed 255527@main (f6f2c95eb900): <https://commits.webkit.org/255527@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462983 [details].
Radar WebKit Bug Importer
Comment 5 2022-10-14 03:50:18 PDT
<rdar://problem/101166942>
EWS
Comment 6 2022-10-25 09:53:54 PDT
Committed 252432.665@safari-7614-branch (c10d7be58084): <https://commits.webkit.org/252432.665@safari-7614-branch> Reviewed commits have been landed. Closing PR #158 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.