Summary: | Fix crash of Chromium port in use of BackForwardList in SVG images | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Hin-Chung Lam <hclam> | ||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED DUPLICATE | ||||||||
Severity: | Normal | CC: | dglazkov, maruel | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
Attachments: |
|
Description
Hin-Chung Lam
2009-03-16 17:52:09 PDT
Created attachment 28673 [details]
patch
Review in Chromium: http://codereview.chromium.org/42265/show maruel already fixed this: http://trac.webkit.org/changeset/41824 "if (m_client)" is only performed on close(), this check should be added to other functions as well. Created attachment 28755 [details]
adding if (m_client) check to other methods
Comment on attachment 28755 [details]
adding if (m_client) check to other methods
Since maruel has patched the class and initialize m_client as NULL, we should avoid using m_client in this case in all methods too.
This was discussed. Please see: https://bugs.webkit.org/show_bug.cgi?id=24398#c6 Comment on attachment 28755 [details]
adding if (m_client) check to other methods
I would have just added an ASSERT(m_client) before these calls in all cases:
- return m_client->backListCount();
+ if (m_client)
+ return m_client->backListCount();
+ ASSERT_NOT_REACHED();
+ return 0;
No need to work hard to crash only in debug mode.
The changelog should mention the bug url.
Also is there no way to test this? There should be a layout test if at all possible.
|