Bug 246051 – [Outline] Outline painting should be able to call BorderPainter with border-radius info

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

ssia

[zalan]

Created attachment 462800 [details]
Patch

[Antti Koivisto]

Comment on attachment 462800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462800&action=review

> Source/WebCore/rendering/BorderPainter.h:47
> +    struct Sides {
> +        RoundedRect outerBorder;
> +        RoundedRect innerBorder;
> +        RoundedRect unadjustedInnerBorder;
> +        std::optional<BorderData::Radii> radii { };
> +        const BorderEdges& edges;
> +        bool haveAllSolidEdges { true };
> +        BackgroundBleedAvoidance bleedAvoidance { BackgroundBleedNone };
> +        bool includeLogicalLeftEdge { true };
> +        bool includeLogicalRightEdge { true };
> +        bool appliedClipAlready { false };
> +    };

"Sides" seems like a strange name for this. I'd expect it would have four sides as a member or something. I don't have a suggestion though.

[zalan]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 462800 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462800&action=review
> 
> > Source/WebCore/rendering/BorderPainter.h:47
> > +    struct Sides {
> > +        RoundedRect outerBorder;
> > +        RoundedRect innerBorder;
> > +        RoundedRect unadjustedInnerBorder;
> > +        std::optional<BorderData::Radii> radii { };
> > +        const BorderEdges& edges;
> > +        bool haveAllSolidEdges { true };
> > +        BackgroundBleedAvoidance bleedAvoidance { BackgroundBleedNone };
> > +        bool includeLogicalLeftEdge { true };
> > +        bool includeLogicalRightEdge { true };
> > +        bool appliedClipAlready { false };
> > +    };
> 
> "Sides" seems like a strange name for this. I'd expect it would have four
> sides as a member or something. I don't have a suggestion though.
I'll try to think of a better name -will come back to it.

[EWS]

Committed 255207@main (dfee462561b1): <https://commits.webkit.org/255207@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462800 [details].

[Radar WebKit Bug Importer]

<rdar://problem/100836548>