Summary: | Subgrid is not aligned correctly with miscalculated gap and page crashes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Christopher Kirk-Nielsen <chriskirknielsen+wkbugs> | ||||||
Component: | Layout and Rendering | Assignee: | Matt Woodrow <mattwoodrow> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, karlcow, mattwoodrow, ntim, simon.fraser, webkit-bug-importer, zalan | ||||||
Priority: | P2 | Keywords: | BrowserCompat, InRadar | ||||||
Version: | Safari 16 | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | https://codepen.io/chriskirknielsen/pen/dyeeRYY | ||||||||
See Also: | https://github.com/web-platform-tests/wpt/pull/36965 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 202115 | ||||||||
Attachments: |
|
Description
Christopher Kirk-Nielsen
2022-10-01 16:20:40 PDT
Created attachment 462768 [details]
rendering in safari, firefox, chrome
Tested on macOS 13.0
---
Safari Technology Preview 16.0 18615.1.6.2 (STP 154)
Firefox Nightly 107.0a1 10722.9.30
Google Chrome Canary 108.0.5336.0 5336.0
3 different renderings.
(In reply to Karl Dubost from comment #1) > Google Chrome Canary 108.0.5336.0 5336.0 Is that with subgrid support enabled? (In reply to Tim Nguyen (:ntim) from comment #2) > Is that with subgrid support enabled? In chrome://flags/ there is nothing to enable subgrid. (Version 108.0.5338.0 (Official Build) canary (arm64)) (In reply to Karl Dubost from comment #3) > (In reply to Tim Nguyen (:ntim) from comment #2) > > Is that with subgrid support enabled? > > In chrome://flags/ there is nothing to enable subgrid. > (Version 108.0.5338.0 (Official Build) canary (arm64)) Pretty sure you need --enable-blink-feature=LayoutNGSubgrid as a command line argument still. I can't reproduce any crashes here, but I do see a bug with gap. It looks like there's not great interop here (I see differences in handling with Chrome too, even with subgrid support enabled). I think Firefox is right for your test case though. Will try fix and add a few new WPT tests for this. Pull request: https://github.com/WebKit/WebKit/pull/6193 Committed 256621@main (87d76d7dac68): <https://commits.webkit.org/256621@main> Reviewed commits have been landed. Closing PR #6193 and removing active labels. |