Bug 245717

Summary: Unreviewed mark css3/scroll-snap/scroll-snap-drag-scrollbar-thumb-with-relayouts.html flaky
Product: WebKit Reporter: Nikos Mouchtaris <nmouchtaris>
Component: ScrollingAssignee: Nikos Mouchtaris <nmouchtaris>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ntim, ryanhaddad, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=245164
https://bugs.webkit.org/show_bug.cgi?id=245989

Description Nikos Mouchtaris 2022-09-26 20:43:47 PDT
Unreviewed mark css3/scroll-snap/scroll-snap-drag-scrollbar-thumb-with-relayouts.html flaky
Comment 1 Radar WebKit Bug Importer 2022-09-26 20:47:27 PDT
<rdar://problem/100441454>
Comment 2 Nikos Mouchtaris 2022-09-26 20:49:08 PDT
Pull request: https://github.com/WebKit/WebKit/pull/4740
Comment 3 EWS 2022-09-26 20:53:21 PDT
Test gardening commit 254895@main (37175e4a2c73): <https://commits.webkit.org/254895@main>

Reviewed commits have been landed. Closing PR #4740 and removing active labels.
Comment 4 Alexey Proskuryakov 2022-09-26 22:44:55 PDT
This test appears to have had a pretty sharp cut-off when it started failing. Can't we find the culprit, and revert?

https://results.webkit.org/?suite=layout-tests&test=css3%2Fscroll-snap%2Fscroll-snap-drag-scrollbar-thumb-with-relayouts.html

@@ -1,10 +1,11 @@
-250
+0
 180
-PASS dragging the horizontal scrollbar thumb snapped
-PASS relayouts should not have snapped back
+FAIL dragging the horizontal scrollbar thumb snapped
+FAIL relayouts should not have snapped back
 PASS dragging the vertical scrollbar thumb snapped
 PASS relayouts should not have snapped back
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
Comment 5 Nikos Mouchtaris 2022-09-27 00:20:33 PDT
This is likely caused by https://github.com/WebKit/WebKit/commit/5ed2b1dffea4b8da9c99f3e9eee1e792b66f37ef. This test will be fixed shortly by this pr: https://github.com/WebKit/WebKit/pull/4336.
Comment 6 Tim Nguyen (:ntim) 2022-09-27 07:10:08 PDT
Yeah I confirmed locally that https://github.com/WebKit/WebKit/pull/4336 fixes the flaky test (both manually and using run-webkit-tests). Nikos, can you make sure that PR removes the annotation added here?