Bug 245682
Summary: | imported/w3c/web-platform-tests/content-security-policy/inheritance/history(-iframe).sub.html has failing subtests | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryan Reno <rreno> |
Component: | History | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED CONFIGURATION CHANGED | ||
Severity: | Normal | CC: | beidson, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Bug Depends on: | 246093 | ||
Bug Blocks: |
Ryan Reno
Both tests have failing subtests for local schemes. Some failures may be test harness, web driver, or reporting API issues but Blob URLs currently don't follow the spec for storing PolicyContainer in history.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/100415046>
Ryan Reno
My mistake - blob URLs do follow the spec for history. That is, we don't store them in history at all. Instead they should be stored in the appropriate BlobRegistry. It appears the PolicyContainer is appropriately stored in the BlobData class.
These tests seem to be quite flaky when hosting them with run-webkit-httpd and navigating to them with Safari and MiniBrowser. They either pass, fail, or timeout.
They consistently fail only the Blob URL cases via WebKitTestRunner and on WPT though.
Ryan Reno
This is probably a bug in the inheritance logic in DocumentWriter::begin. It looks like we unconditionally (for blob URLs) inherit from the navigation initiator. We should be inheriting from the PolicyContainer stored in the Blob URL store.
Ryan Reno
246093 contains the PR to fix this. Instead of handling blob URL inheritance in WebContent process, we can use the PolicyContainer which already exists in the blob store in the Network process.