Bug 245611
Summary: | Align "UA" stylesheet for "audio" with Other browsers | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW | ||
Severity: | Normal | CC: | akeerthi, annevk, bfulgham, karlcow, rniwa, simon.fraser, webkit-bug-importer, zalan |
Priority: | P2 | Keywords: | BrowserCompat, InRadar |
Version: | Safari Technology Preview | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=88105 |
Ahmad Saleem
Hi Team,
Thanks for making Webkit awesome.
While looking into other browsers UA Style sheet, I noted both Blink and Gecko has following in their UA stylesheet, while we don't:
audio:not([controls]) {
display: none !important;
}
--> Gecko goes even beyond and have following:
audio[controls] {
/* This ensures that intrinsic sizing can reliably shrinkwrap our
controls (which are also always horizontal) and produce a
reasonable intrinsic size from them. */
writing-mode: horizontal-tb !important;
}
______
I tried to find these references in HTML Specs but couldn't find them but was thinking to align with other browsers, I think we can safely at the first one in "html.css" and see through EWS and what happens, in case of other, appreciate input from others.
I also looked into HTML audio element tests and Safari do pass all of them similar to other browsers so I think either WPT does not have coverage or I am not familiar with related test.
Just wanted to have a bug report for any future discussion.
Thanks!
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Anne van Kesteren
Hey Ahmad, thanks for filing this!
From https://html.spec.whatwg.org/#embedded-content-rendering-rules:
> When an audio element is not exposing a user interface, the user agent is expected to force its 'display' property to compute to 'none', irrespective of CSS rules.
"exposing a user interface" is defined as such:
> If the [controls] attribute is present, or if scripting is disabled for the media element, then the user agent should expose a user interface to the user.
It seems the CSS in Blink and Gecko does not capture the scripting-related requirement.
For `writing-mode` we should probably file an issue against whatwg/html to discuss getting that standardized. Would you care to file that?
Ahmad Saleem
(In reply to Anne van Kesteren from comment #1)
> Hey Ahmad, thanks for filing this!
>
> From https://html.spec.whatwg.org/#embedded-content-rendering-rules:
>
> > When an audio element is not exposing a user interface, the user agent is expected to force its 'display' property to compute to 'none', irrespective of CSS rules.
>
> "exposing a user interface" is defined as such:
>
> > If the [controls] attribute is present, or if scripting is disabled for the media element, then the user agent should expose a user interface to the user.
>
> It seems the CSS in Blink and Gecko does not capture the scripting-related
> requirement.
>
> For `writing-mode` we should probably file an issue against whatwg/html to
> discuss getting that standardized. Would you care to file that?
Done - https://github.com/whatwg/html/issues/8316
Radar WebKit Bug Importer
<rdar://problem/100644782>