Bug 24559

Summary: Need to port JSC fix to V8 in order to fix layout test onload-single-line-comment.html
Product: WebKit Reporter: Jian Li <jianli>
Component: WebCore Misc.Assignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Patch
dglazkov: review+
Proposed Patch none

Description Jian Li 2009-03-12 14:03:28 PDT
Need to port JSC fix to V8 in order to fix layout test onload-single-line-comment.html.
Comment 1 Jian Li 2009-03-12 14:06:08 PDT
Created attachment 28555 [details]
Proposed Patch
Comment 2 Dimitri Glazkov (Google) 2009-03-13 09:36:39 PDT
Comment on attachment 28555 [details]
Proposed Patch

So this is just to match JSC's behavior?
Comment 3 Jian Li 2009-03-13 10:02:37 PDT
(In reply to comment #2)
> (From update of attachment 28555 [details] [review])
> So this is just to match JSC's behavior?
> 

This is to fix layout test failure in chromium. I ported JSC's fix.
Comment 4 Dimitri Glazkov (Google) 2009-03-13 10:06:11 PDT
Sounds good, please mention the revision number of the JSC change that you ported in the ChangeLog.
Comment 5 Jian Li 2009-03-13 10:18:27 PDT
Created attachment 28581 [details]
Proposed Patch
Comment 6 David Levin 2009-03-13 10:22:59 PDT
Assigned to levin for landing.
Comment 7 David Levin 2009-03-13 10:33:31 PDT
Committed in r41671.