Bug 24559

Summary:

Need to port JSC fix to V8 in order to fix layout test onload-single-line-comment.html

Product:

WebKit

Reporter:

Jian Li <jianli>

Component:

WebCore Misc.

Assignee:

David Levin <levin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed Patch	dglazkov: review+
Proposed Patch	none

Jian Li

Reported 2009-03-12 14:03:28 PDT

Need to port JSC fix to V8 in order to fix layout test onload-single-line-comment.html.

Attachments
Proposed Patch (1.84 KB, patch) 2009-03-12 14:06 PDT, Jian Li	dglazkov: review+	Details Formatted Diff Diff
Proposed Patch (1.85 KB, patch) 2009-03-13 10:18 PDT, Jian Li	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jian Li

Comment 1 2009-03-12 14:06:08 PDT

Created attachment 28555 [details] Proposed Patch

Dimitri Glazkov (Google)

Comment 2 2009-03-13 09:36:39 PDT

Comment on attachment 28555 [details] Proposed Patch So this is just to match JSC's behavior?

Jian Li

Comment 3 2009-03-13 10:02:37 PDT

(In reply to comment #2) > (From update of attachment 28555 [details] [review]) > So this is just to match JSC's behavior? > This is to fix layout test failure in chromium. I ported JSC's fix.

Dimitri Glazkov (Google)

Comment 4 2009-03-13 10:06:11 PDT

Sounds good, please mention the revision number of the JSC change that you ported in the ChangeLog.

Jian Li

Comment 5 2009-03-13 10:18:27 PDT

Created attachment 28581 [details] Proposed Patch

David Levin

Comment 6 2009-03-13 10:22:59 PDT

Assigned to levin for landing.

David Levin

Comment 7 2009-03-13 10:33:31 PDT

Committed in r41671.

Note You need to log in before you can comment on or make changes to this bug.