Bug 245568

Summary: [LFC][Integration] Add a Layout::Box pointer to RenderObject
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Antti Koivisto
Reported 2022-09-23 03:00:26 PDT
Replace the map in LineLayout with a direct pointer in render objects. This is faster and also uses less memory in most cases since with expanded IFC coverage majority of renderers already end up in these maps.
Attachments
Patch (28.80 KB, patch)
2022-09-23 03:19 PDT, Antti Koivisto
no flags
Patch for landing (28.37 KB, patch)
2022-09-23 23:24 PDT, Antti Koivisto
no flags
Radar WebKit Bug Importer
Comment 1 2022-09-23 03:00:49 PDT
Antti Koivisto
Comment 2 2022-09-23 03:19:28 PDT
zalan
Comment 3 2022-09-23 06:33:04 PDT
Comment on attachment 462559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462559&action=review v.nice! > Source/WebCore/layout/layouttree/LayoutContainerBox.cpp:101 > +} trailing whitespace. > Source/WebCore/rendering/RenderView.h:233 > + std::unique_ptr<Layout::InitialContainingBlock> m_initialContainingBlock; can this be just a UniqueRef<> ?
Antti Koivisto
Comment 4 2022-09-23 23:24:49 PDT
Created attachment 462576 [details] Patch for landing
EWS
Comment 5 2022-09-24 00:41:00 PDT
Committed 254822@main (de27a5057c3d): <https://commits.webkit.org/254822@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462576 [details].
Note You need to log in before you can comment on or make changes to this bug.