Bug 245513

Summary:

TextureMapperGL: edge distance anti-aliasing should use 2D distance to calculate v_antialias varing variable

Product:

WebKit

Reporter:

Fujii Hironori <Hironori.Fujii>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

cmarcelo, ews-watchlist, kondapallykalyan, luiz

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
antialiasing-z-positions.html	none
WIP patch	ews-feeder: commit-queue-

Fujii Hironori

Reported 2022-09-21 21:01:16 PDT

Created attachment 462527 [details] antialiasing-z-positions.html TextureMapperGL: edge distance anti-aliasing should use 2D distance to calculate v_antialias varing variable > float viewportSpaceDistance = distance(centerInViewportCoordinates, controlPointInViewportCoordinates); This code calculates the distance in homogeneous coordinates. z and w are included.

Attachments
antialiasing-z-positions.html (849 bytes, text/html) 2022-09-21 21:01 PDT, Fujii Hironori	no flags	Details
WIP patch (2.15 KB, patch) 2022-09-21 21:01 PDT, Fujii Hironori	ews-feeder: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2022-09-21 21:01:53 PDT

Created attachment 462528 [details] WIP patch

Fujii Hironori

Comment 2 2022-09-21 21:04:41 PDT

Comment on attachment 462528 [details] WIP patch View in context: https://bugs.webkit.org/attachment.cgi?id=462528&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:113 > + float viewportSpaceDistance = distance(centerInViewportCoordinates.xy / centerInViewportCoordinates.w, controlPointInViewportCoordinates.xy / controlPointInViewportCoordinates.w); We should avoid divisions. bug#245265 is going to solve this bug by calculating the denominator separately.

Fujii Hironori

Comment 3 2022-09-26 22:46:55 PDT

*** This bug has been marked as a duplicate of bug 245265 ***

Note You need to log in before you can comment on or make changes to this bug.