Bug 24548 – createElementNS("", name) should create an element in null namespace

• Component: DOM
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

This is a change in DOM 3 Core over DOM 2 Core - empty strings are converted to null when used for namespace URIs. Firefox and Opera both work this way.

See <http://lists.w3.org/Archives/Public/public-webapps/2009JanMar/0720.html>.

[Alexey Proskuryakov]

Created attachment 28530 [details]
fix it radically

[Alexey Proskuryakov]

We had bug 15172 filed about the same issue with setAttributeNS already.

[Julien Chaffraix]

I think your change will have the side effect of changing how createAttributeNS("", name) works. Is it covered by other test case(s) or am I missing something?

[Alexey Proskuryakov]

Yes, this is why I called it a radical fix - it will fix all NS APIs at once (and they should all have this behavior per DOM 3 Core).

Is createAttributeNS a special case that shouldn't be fixed for some reason?

[Julien Chaffraix]

(In reply to comment #4)
> Yes, this is why I called it a radical fix - it will fix all NS APIs at once
> (and they should all have this behavior per DOM 3 Core).
> 
> Is createAttributeNS a special case that shouldn't be fixed for some reason?

I have not tested so I would say no. createAttributeNS was just a example of other NS methods that would be impacted: I was just interested in why you were only testing one among them as it may have have given a compatibility reason to not fix one (note that I would rather keep a uniform behaviour in NS methods as you are doing).

[Darin Adler]

Comment on attachment 28530 [details]
fix it radically

r=me

[Alexey Proskuryakov]

Committed <http://trac.webkit.org/changeset/41700>.

[Alexey Proskuryakov]

(I've added a test for setAttributeNS).

[Lucas Forschler]

Mass moving XML DOM bugs to the "DOM" Component.