Bug 245465
| Summary: | recordStrokeLineWithColorAndThickness doesn't mark the state as having applied changes. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Matt Woodrow <mattwoodrow> |
| Component: | Layout and Rendering | Assignee: | Matt Woodrow <mattwoodrow> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, george.pomas, jon, jwmerrill, paul.neave, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Matt Woodrow
<rdar://98994290>
The recordStrokeLineWithColorAndThickness optimised path skips serialising the state object, but fails to mark that we've applied the necessary changes.
This means that you can then change state back to it's original value, and we won't detect that it changed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Matt Woodrow
Pull request: https://github.com/WebKit/WebKit/pull/4560
Alexey Proskuryakov
*** Bug 245145 has been marked as a duplicate of this bug. ***
EWS
Committed 254889@main (aabdfc49a52b): <https://commits.webkit.org/254889@main>
Reviewed commits have been landed. Closing PR #4560 and removing active labels.
Alexey Proskuryakov
*** Bug 246498 has been marked as a duplicate of this bug. ***
Paul Neave
Does anyone know when this fix will make its way into Safari? Issue is still present in iOS 16.0.3 and Safari TP. Thanks.
Alexey Proskuryakov
Please try it out with iOS 16.2 beta.
Apple does not comment on future releases, so we cannot discuss when it will be in shipping Safari.
Alexey Proskuryakov
*** Bug 247731 has been marked as a duplicate of this bug. ***