Bug 245424

Summary:	Rename unclear usage of Color::isValid() to explicit isCurrentColor()
Product:	WebKit	Reporter:	Matthieu Dubet <m_dubet>
Component:	WebCore Misc.	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Matthieu Dubet

Reported 2022-09-20 06:50:46 PDT

Due to the representation of "current color" as "invalid color" in WebCore, they are two functionally equivalent functions is the codebase : - Color::isValid() - RenderStyle::isCurrentColor(Color) (which is implemented as "return !color.isValid()). The second one makes the intention of the check clearer and should be preferred.

Attachments
Add attachment proposed patch, testcase, etc.

Matthieu Dubet

Comment 1 2022-09-20 06:53:07 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4528

EWS

Comment 2 2022-09-20 10:26:16 PDT

Committed 254683@main (0b28244472f0): <https://commits.webkit.org/254683@main> Reviewed commits have been landed. Closing PR #4528 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-09-20 10:27:19 PDT

<rdar://problem/100178146>

Note You need to log in before you can comment on or make changes to this bug.