Bug 245415
| Summary: | worker and other values are valid keyword for the 'as' property in link preload | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Karl Dubost <karlcow> |
| Component: | DOM | Assignee: | youenn fablet <youennf> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, cdumez, webkit-bug-importer |
| Priority: | P2 | Keywords: | BrowserCompat, InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=231150 https://bugs.webkit.org/show_bug.cgi?id=274591 |
||
Karl Dubost
When a document contains:
<link rel="preload" href="main.js" as="worker" />
Safari reports:
<link rel=preload> must have a valid `as` value
Probably a couple of tests are missing from
https://wpt.fyi/results/html/syntax/speculative-parsing/generated/page-load?label=master&label=experimental&aligned&view=subtest&q=preload
or https://wpt.fyi/results/fetch/metadata/preload.https.sub.html?label=master&label=experimental&aligned&view=subtest&q=preload
or in
https://wpt.fyi/results/preload/reflected-as-value.html?label=master&label=experimental&aligned&view=subtest&q=preload
The fetch spec definition:
https://fetch.spec.whatwg.org/#concept-request-destination
> A request has an associated destination, which is the empty string, "audio", "audioworklet", "document", "embed", "font", "frame", "iframe", "image", "manifest", "object", "paintworklet", "report", "script", "serviceworker", "sharedworker", "style", "track", "video", "worker", or "xslt". Unless stated otherwise it is the empty string.
>
> A request’s destination is script-like if it is "audioworklet", "paintworklet", "script", "serviceworker", "sharedworker", or "worker".
It seems there are a couple of values which are not defined such as video for example.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Karl Dubost
It seems to be defined in
https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLLinkElement.cpp#236-253
Radar WebKit Bug Importer
<rdar://problem/100161255>
Karl Dubost
Error message is coming from
https://searchfox.org/wubkat/rev/98b6bc461792c83386d8a7bb26363c41fc42f77e/Source/WebCore/loader/LinkLoader.cpp#235-240
Karl Dubost
Related https://github.com/whatwg/html/issues/8332
youenn fablet
Pull request: https://github.com/WebKit/WebKit/pull/5367
EWS
Committed 255669@main (e53707dae94c): <https://commits.webkit.org/255669@main>
Reviewed commits have been landed. Closing PR #5367 and removing active labels.