Bug 245222
| Summary: | REGRESSION(250548@main): Early WebProcess exit on 32-bit platforms since memory limit is zero | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cdumez, cgarcia, darin, loic.yhuel, mafm, magomez, mcatanzaro, nham, webkit-bug-importer, zdobersek |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=241012 | ||
Olivier Blin
In 250548@main, the memory limit in MemoryPressureHandler is set to a least 7 GB for active process.
This value is stored in a size_t variable, but this is limited to 4 GB on 32-bit platforms.
The memory limit is truncated down to 0, which triggers a WebProcess exit after the first MemoryPressure check.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Olivier Blin
Pull request: https://github.com/WebKit/WebKit/pull/4381
Miguel Gomez
Folks, this is already being handled in https://bugs.webkit.org/show_bug.cgi?id=241012.
The PR for this addresses the value overflow, but what should be done is that WebKitGTK and WPE shouldn't use those values at all.
Chris Dumez
(In reply to Miguel Gomez from comment #2)
> Folks, this is already being handled in
> https://bugs.webkit.org/show_bug.cgi?id=241012.
>
> The PR for this addresses the value overflow, but what should be done is
> that WebKitGTK and WPE shouldn't use those values at all.
I think https://github.com/WebKit/WebKit/pull/4381 is valuable no matter what.
If you want to disable this handling for WebKitGTK and WPE and fine but that's a separate issue from the overflow handling on 32bit.
EWS
Committed 254533@main (b0895ea02d48): <https://commits.webkit.org/254533@main>
Reviewed commits have been landed. Closing PR #4381 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/99989909>
Miguel Gomez
*** Bug 241012 has been marked as a duplicate of this bug. ***