Bug 24517

Summary:

REGRESSION (r41552): innerHTML does an updateLayout -- unneeded and can be slow

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

DOM

Assignee:

Darin Adler <darin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fishd

Priority:

Keywords:

Regression

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
work in progress -- missing ChangeLog but otherwise may be ready to go	none
patch	none
improved patch	hyatt: review+

Darin Adler

Reported 2009-03-11 09:58:46 PDT

I caused this regression recently and Hyatt and I discussed a fix.

Attachments
work in progress -- missing ChangeLog but otherwise may be ready to go (6.67 KB, patch) 2009-03-11 09:59 PDT, Darin Adler	no flags	Details Formatted Diff Diff
patch (9.40 KB, patch) 2009-03-11 17:46 PDT, Darin Adler	no flags	Details Formatted Diff Diff
improved patch (9.70 KB, patch) 2009-03-13 06:49 PDT, Darin Adler	hyatt: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Darin Adler

Comment 1 2009-03-11 09:59:25 PDT

Created attachment 28482 [details] work in progress -- missing ChangeLog but otherwise may be ready to go

Darin Fisher (:fishd, Google)

Comment 2 2009-03-11 15:51:52 PDT

Just an FYI: On one of the Chrome performance tests, I found this to be about a 3-4% regression. That test has about 700 assignments to innerHTML over the course of 56 pages.

Darin Adler

Comment 3 2009-03-11 17:46:08 PDT

Created attachment 28507 [details] patch

Darin Adler

Comment 4 2009-03-11 20:25:27 PDT

Given their interest in this bug, I'm hoping that Dave Hyatt or Darin Fisher will review the patch. This is the fix I discussed with Hyatt.

Darin Adler

Comment 5 2009-03-11 20:25:55 PDT

I could make the AppendMarkupState thing a bit more elegant by making that "state" object into a class, with the appendMarkup function a member function.

Darin Adler

Comment 6 2009-03-13 06:49:58 PDT

Created attachment 28578 [details] improved patch

Dave Hyatt

Comment 7 2009-03-17 16:33:44 PDT

Comment on attachment 28578 [details] improved patch r=me

Darin Adler

Comment 8 2009-03-17 16:35:33 PDT

http://trac.webkit.org/changeset/41791

Note You need to log in before you can comment on or make changes to this bug.