Summary: | Holepunch missing after video source change | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Olivier Blin <olivier.blin> | ||||||
Component: | WPE WebKit | Assignee: | Miguel Gomez <magomez> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aperez, bugs-noreply, cgarcia, Hironori.Fujii, loic.yhuel, magomez, zdobersek | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Olivier Blin
2022-09-13 05:46:23 PDT
Created attachment 462353 [details]
tentative fix
The issue is quite complicated to reproduce in my system. I was able to see it only once in tens of executions. This is because it has to happen that the old player is destroyed and the new one created before there's a layerFlush, so the CoordinatedGraphicsScene can be in the situation where a layer's proxy is replaced with a new one. Most of the times there's a layerFlush between the destruction of the old player and the creation of the new one, so the problem doesn't reproduce.
Anyway, I think the fix is as simple as doing the invalidation of the old proxies before activating the new ones.
Olivier, as you seem to be able to reproduce the issue reliably, could you give a test to this patch and check whether it fixes the problem?
Miguel: thank you, this fixes the issue for me. I could reproduce the issue on my laptop, but it has been first detected on set-top boxes with less powerful CPUs. Pull request: https://github.com/WebKit/WebKit/pull/4379 Committed 254548@main (f994a1b3e3dc): <https://commits.webkit.org/254548@main> Reviewed commits have been landed. Closing PR #4379 and removing active labels. |