Bug 245070
| Summary: | [GTK][WPE] Stop using injected bundle messages for implementing resource loader API | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
| Component: | WebKitGTK | Assignee: | Carlos Garcia Campos <cgarcia> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, bugs-noreply, cdumez, youennf |
| Priority: | P2 | Keywords: | Gtk |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Carlos Garcia Campos
At the beginning this was not exposed in WebKit2 APIS, so we had to use custom injected bundle messages to keeps exposing this.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
I tried using API::ResourceLoadClient but it's not enough for what we have now. It missed the resources loaded from the disk cache (this sounds like bug because there's loadedFromCache in API::ResourceLoadInfo) and also the ones loaded from the memory cache, because this client receives messages from the network process, not the web process. So, can we just add a resource load client specific for GTK and WPE to stop using injected bundle messages?
Carlos Garcia Campos
Alex, would you be ok with adding internal api just for GTK/WPE to implement web resources loader from the web process but without using injected bundle?
Carlos Garcia Campos
Alex? Youenn? Chris?
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/6036
EWS
Committed 256388@main (051a04847864): <https://commits.webkit.org/256388@main>
Reviewed commits have been landed. Closing PR #6036 and removing active labels.