Summary: | Geolocation in Safari differs from the spec, no Coordinates attribute on Position | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Greg Bolsinga <bolsinga> | ||||||||
Component: | WebCore JavaScript | Assignee: | Greg Bolsinga <bolsinga> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | koivisto, sam | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Greg Bolsinga
2009-03-10 18:56:06 PDT
Created attachment 28462 [details]
This patch implements the needed changes
This add a Coordinates method to the Position in Geolocation.
It is also missing PositionOptions.maximumAge. Created attachment 28493 [details]
Updated patch includes maximumAge in PositionOptions
Updated to include maximumAge.
Created attachment 28494 [details]
forgot to update ChangeLog file
Comment on attachment 28494 [details]
forgot to update ChangeLog file
r=me, looks good.
Geolocation related sources would probably deserve a subdirectory of their own at some point.
bolsinga:WebKit bolsinga$ svn commit Sending WebCore/ChangeLog Sending WebCore/DerivedSources.make Sending WebCore/GNUmakefile.am Sending WebCore/WebCore.pro Sending WebCore/WebCore.scons Sending WebCore/WebCore.vcproj/WebCore.vcproj Sending WebCore/WebCore.xcodeproj/project.pbxproj Sending WebCore/WebCoreSources.bkl Sending WebCore/bindings/js/JSGeolocationCustom.cpp Adding WebCore/page/Coordinates.cpp Adding WebCore/page/Coordinates.h Adding WebCore/page/Coordinates.idl Sending WebCore/page/Geoposition.cpp Sending WebCore/page/Geoposition.h Sending WebCore/page/Geoposition.idl Sending WebCore/page/PositionOptions.h Sending WebCore/platform/mac/GeolocationServiceMac.mm Transmitting file data ................. Committed revision 41650. |