Bug 245018
| Summary: | angle_version.h and angle_version_info.h should not use the same header guard macro | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | ANGLE | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | dino, kbr, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
angle_version.h and angle_version_info.h should not use the same header guard macro.
Currently they both use:
#ifndef COMMON_VERSION_H_
#define COMMON_VERSION_H_
[...]
#endif // COMMON_VERSION_H_
Found by CodeQL.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/99770768>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/4212
EWS
Committed 254370@main (1a61b3dac3ce): <https://commits.webkit.org/254370@main>
Reviewed commits have been landed. Closing PR #4212 and removing active labels.
Kimmo Kinnunen
https://chromium-review.googlesource.com/c/angle/angle/+/3891372
https://bugs.chromium.org/p/angleproject/issues/detail?id=7650