Bug 244982 – css-pseudo: ::placeholder should not support 'writing-mode', 'direction', and 'text-orientation'

• Component: CSS
• Status: RESOLVED FIXED

[Ahmad Saleem]

It is to align Webkit with Web-Spec:

https://drafts.csswg.org/css-pseudo-4/#placeholder-pseudo
> All properties that apply to the ::first-line pseudo-element also apply to the ::placeholder pseudo-element.

and
https://drafts.csswg.org/css-pseudo-4/#first-line-styling
> User agents may apply other properties as well except for the following excluded properties:
> * writing-mode
> * direction
> * text-orientation

Current Safari Technology Preview 153 behavior is not aligned with Blink / Chromium, Gecko / Firefox and Web-Spec.

Chrome Commit to Merge - https://chromium.googlesource.com/chromium/src.git/+/68c32d4e9fe24e25e672095253e0f0b2e709ecf4%5E%21/

Where to merge - https://github.com/WebKit/WebKit/blob/main/Source/WebCore/css/html.css#L762

Thanks!

[Ahmad Saleem]

It seems that it does not fix WPT test but since it is to align with web-spec, I think it is still good to merge this change. So I pushed it without change request and let's see. Thanks!

[Ahmad Saleem]

https://github.com/WebKit/WebKit/pull/4172

[EWS]

Committed 254416@main (b79ce718736d): <https://commits.webkit.org/254416@main>

Reviewed commits have been landed. Closing PR #4172 and removing active labels.

[Radar WebKit Bug Importer]

<rdar://problem/99846286>

[Karl Dubost]

Ahmad do you remember which WPT test is you were alluding to?

[Ahmad Saleem]

(In reply to Karl Dubost from comment #5)
> Ahmad do you remember which WPT test is you were alluding to?

https://wpt.fyi/results/css/css-pseudo/placeholder-excluded-properties.html?label=master&label=experimental&aligned&view=subtest&q=placeholder-excluded-properties