Bug 244852

Summary: REGRESSION(252943@main): [GTK] Cannot display https://www.cbsnews.com/
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: aperez, bugs-noreply, cdumez, cgarcia, darin, Hironori.Fujii, mcatanzaro, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232309
Bug Depends on: 244879    
Bug Blocks:    

Michael Catanzaro
Reported 2022-09-06 12:16:05 PDT
After some recent change, probably either WebKitGTK 2.37.91 or else perhaps a change in libsoup, we are no longer able to display https://www.cbsnews.com/. Instead we just see an empty page.
Attachments
Carlos Garcia Campos
Comment 1 2022-09-07 14:39:44 PDT
a697ed80d982828b800582af5c283f19ed6aba97 is the first bad commit commit a697ed80d982828b800582af5c283f19ed6aba97 Date: Thu Jul 28 23:43:19 2022 -0700 link elements should be able to fire more than one load / error event https://bugs.webkit.org/show_bug.cgi?id=232309 Reviewed by Chris Dumez and Darin Adler. Based on a patch written by Chris Dumez. This patch makes link element emit more than one load event each time resource is loaded, and fixes the bug that setting rel content attribute to the same value resulted in the resource to be reloaded. New behavior matches that of Chrome and Firefox. * LayoutTests/TestExpectations: Unskip now passing tests. * LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt: Added. * LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once.html: Added. * LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once-expected.txt: Added. * LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events-expected.txt: * LayoutTests/platform/mac-wk1/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt: * LayoutTests/platform/mac-wk1/fast/dom/HTMLLinkElement/link-stylesheet-load-once-expected.txt: * LayoutTests/platform/win/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt: * LayoutTests/platform/win/fast/dom/HTMLLinkElement/link-stylesheet-load-once-expected.txt: * Source/WebCore/html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::parseAttribute): (WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources): * Source/WebCore/html/HTMLLinkElement.h: * Source/WebCore/html/LinkRelAttribute.h: (WebCore::operator==): Added. Canonical link: https://commits.webkit.org/252943@main
Carlos Garcia Campos
Comment 2 2022-09-07 14:41:07 PDT
The reason why page doesn't load is because the web process is at 100% CPU doing layouts all the time.
Ryosuke Niwa
Comment 3 2022-09-07 14:43:18 PDT
This patch got reverted.
Michael Catanzaro
Comment 4 2022-09-07 15:15:24 PDT
OK, just yesterday, in bug #244879. I'll add it to the backport list. And now you have another website to test on before trying to re-land. ;) Thanks for bisecting it, Carlos.
Adrian Perez
Comment 5 2022-09-07 15:18:18 PDT
I have already cherry-picked the revert in the 2.38 release branch, it will be included in the next release.
Fujii Hironori
Comment 6 2022-09-07 20:11:36 PDT
> <link rel="stylesheet" href="/fly/bundles/cbsnewscontent/css/responsive.min.css?v=8bc2e0f78408a4b8086da85d60d8c0a5" media="print" onload="this.media='all'"> 'media' attribute is modified.
Ryosuke Niwa
Comment 7 2022-09-14 21:41:38 PDT
*** This bug has been marked as a duplicate of bug 244879 ***
Note You need to log in before you can comment on or make changes to this bug.