| Summary: | REGRESSION (r41467): Page Down key scrolls two pages | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | nobody <a4list> | ||||
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Major | CC: | adele, alice.barraclough, ap, dharris+webkit, jwalden+bwo, nickptar, rajiv, tony, zwarich | ||||
| Priority: | P1 | Keywords: | InRadar, Regression | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
nobody
2009-03-09 20:00:16 PDT
Are you seeing this on all sites? I cannot reproduce the problem with r41550 (although I have a notebook, so it's Fn+Down, not PgDown for me). Yes, every website. The "Page Down" key is located on keyboard among Home/End/Delete/Page Up/Page Down/Insert buttons. (btw, "Page Up" scrolls the wrong distance, also.) Problem continues in r41545. Weird, it suddenly started to happen to me. Maybe I was testing an old version previously. Logging editing commands, I see that doCommandBySelector:"scrollPageDown:" is invoked twice for each PageDown. i'm seeing this in WebKit r41545 with safari 4 public beta installed: Version 4 Public Beta (5528.16, r41545), on a mac with an "extended keyboard" with actual page up/page down keys. the problem is not just with page down but also with page up. this was broken in Changeset 41467 for trunk/WebKit/mac/WebView/WebHTMLView.mm in order to fix bug #24079. see http://trac.webkit.org/changeset/41467 building webkit r41660 with that change reversed fixes the problems described in this bug. Created attachment 28572 [details] patch to fix double page down/page up bug since the selector is passed to super, consider the event handled. code originally introduced in http://trac.webkit.org/changeset/39549 Comment on attachment 28572 [details] patch to fix double page down/page up bug This will cause https://bugs.webkit.org/show_bug.cgi?id=23060 to show up again. To reproduce that bug, try running Mail.app with your patched WebKit. Focus a message in the preview pane, and you'll see that Home, End, Page Up, and Page Down don't work. Here's an experiment we should try. If we added the selectors for Page Up/Down and Home/End to the Editor command table in WebCore, would we still need eventHandled to be false here to get the Mail testcase to work? I値l take this one. *** Bug 24660 has been marked as a duplicate of this bug. *** This problem is not fixed. Some recent versions seemed OK. r41760 again scrolls too far. It seems to be not quite a full page extra, but it is scrolling the wrong distance. The difference in distance scrolled is probably due to the fact that we now use WebCore's scrolling code instead of WebFrameView's. The old bug was absolutely critical, the new bug simply makes the Mac version match the Windows version. While I want to fix the new bug, it's *not* the same thing, so reopening this bug report isn't quite right. (In reply to comment #13) > This problem is not fixed. > > Some recent versions seemed OK. > > r41760 again scrolls too far. According to comment #12, this was committed in r41793 -- which is after r41760. There has been no new nightly build since r41760 (I don't know why). Please try again with a version newer than r41793. seems to be OK in r41844. Thanks! *** Bug 24698 has been marked as a duplicate of this bug. *** |