Bug 244755

Summary:	Stop calling NSDisableScreenUpdates()/NSEnableScreenUpdates()
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Media	Assignee:	Simon Fraser (smfr) <simon.fraser>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Simon Fraser (smfr)

Reported 2022-09-02 20:27:58 PDT

NSDisableScreenUpdates()/NSEnableScreenUpdates() are no-ops for applications linked on Catalina or later. We call these when showing/hiding the fullscreen window, which is UI that webkit controls, so it should be safe to remove them.

Attachments
Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2022-09-02 20:29:43 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3986

EWS

Comment 2 2022-09-07 10:01:28 PDT

Committed 254239@main (0ddb0cb7d5bb): <https://commits.webkit.org/254239@main> Reviewed commits have been landed. Closing PR #3986 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-09-07 10:02:19 PDT

<rdar://problem/99654312>

Note You need to log in before you can comment on or make changes to this bug.