Bug 244746 – AX: Stop unnecessarily caching AXPropertyName::{LayoutCount, PressedIsPresent, DropEffects, ClickPoint, ClassList}

• Component: Accessibility
• Status: RESOLVED FIXED

[Tyler Wilcock]

We only expect these properties to be requested by tests and automation on the Mac (so not actual AX clients), so don't do the work to cache them.

[Radar WebKit Bug Importer]

<rdar://problem/99512111>

[Tyler Wilcock]

Created attachment 462108 [details]
Patch

[chris fleizach]

Comment on attachment 462108 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462108&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:3150
> +    for (unsigned k = 0; k < domClassList.length(); k++)

Can we put length outside the loop to reduce number of times it is called

> Source/WebCore/accessibility/AccessibilityObject.cpp:3151
> +        classList.append(domClassList.item(k).string());

Is there some existing map function that does this?

[Tyler Wilcock]

Created attachment 462111 [details]
Patch

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> Comment on attachment 462108 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462108&action=review
> 
> > Source/WebCore/accessibility/AccessibilityObject.cpp:3150
> > +    for (unsigned k = 0; k < domClassList.length(); k++)
> 
> Can we put length outside the loop to reduce number of times it is called
Fixed.

> > Source/WebCore/accessibility/AccessibilityObject.cpp:3151
> > +        classList.append(domClassList.item(k).string());
> 
> Is there some existing map function that does this?
Unfortunately no. This is a DOMTokenList class rather than a Vector, and it doesn't have a map function.

[EWS]

Committed 254130@main (1ee82a09fde8): <https://commits.webkit.org/254130@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462111 [details].