Bug 244739

Summary: [LFC][IFC] Introduce the concept of "placed" float boxes
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2022-09-02 16:31:36 PDT
ssia
Attachments
Patch (15.15 KB, patch)
2022-09-02 16:37 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (15.16 KB, patch)
2022-09-04 10:25 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (15.16 KB, patch)
2022-09-04 11:27 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2022-09-02 16:37:14 PDT
Created attachment 462107 [details] Patch
Antti Koivisto
Comment 2 2022-09-04 07:37:53 PDT
Comment on attachment 462107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462107&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:66 > + using FloatList = Vector<const InlineItem*>; I suppose the type could also be PlacedFloats because that is the only thing it is used for (for now?).
Antti Koivisto
Comment 3 2022-09-04 07:39:59 PDT
or PlacedFloatItems or something
zalan
Comment 4 2022-09-04 09:08:19 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 462107 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=462107&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:66 > > + using FloatList = Vector<const InlineItem*>; > > I suppose the type could also be PlacedFloats because that is the only thing > it is used for (for now?). The upcoming patch with "overflowing floats" gonna use this type.
zalan
Comment 5 2022-09-04 10:25:17 PDT
Created attachment 462122 [details] Patch
zalan
Comment 6 2022-09-04 11:27:29 PDT
Created attachment 462124 [details] Patch
EWS
Comment 7 2022-09-04 15:56:58 PDT
Committed 254151@main (7bdac4ad13a4): <https://commits.webkit.org/254151@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462124 [details].
Radar WebKit Bug Importer
Comment 8 2022-09-04 15:57:15 PDT
<rdar://problem/99552170>
Note You need to log in before you can comment on or make changes to this bug.