Bug 244711

Summary: [LFC] Remove ENABLE_LAYOUT_FORMATTING_CONTEXT define
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, bfulgham, cdumez, cgarcia, changseok, clopez, cmarcelo, don.olmstead, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, Hironori.Fujii, kondapallykalyan, mcatanzaro, mmaxfield, pdr, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antti Koivisto
Reported 2022-09-02 04:35:00 PDT
LFC is our standard system for inline layout. We don't ever want to compile it out.
Attachments
Patch (192.70 KB, patch)
2022-09-02 04:55 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-09-02 04:35:29 PDT
<rdar://problem/99483972>
Antti Koivisto
Comment 2 2022-09-02 04:55:10 PDT
Created attachment 462094 [details] Patch
zalan
Comment 3 2022-09-02 05:50:19 PDT
Comment on attachment 462094 [details] Patch v.nice.
Michael Catanzaro
Comment 4 2022-09-02 07:40:02 PDT
Comment on attachment 462094 [details] Patch I had been wondering about why this was still gated behind the experimental feature guard ever since you mentioned it was intended to be default everywhere. I don't like running different code on Apple vs. Linux unless there's a strong reason to be different, so this seems good to me. BTW now is the perfect time to enable new features, since the new GTK/WPE stable branch was just created. We have half a year to test changes made now before they reach users.
Antti Koivisto
Comment 5 2022-09-02 07:52:27 PDT
Great!
EWS
Comment 6 2022-09-02 08:46:31 PDT
Committed 254102@main (3a4ed38babac): <https://commits.webkit.org/254102@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462094 [details].
Note You need to log in before you can comment on or make changes to this bug.