Bug 244653
| Summary: | [webkitdirs] Detect when internal builds are using the open-source workspace | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | Tools / Tests | Assignee: | Elliott Williams <emw> |
| Status: | REOPENED | ||
| Severity: | Normal | CC: | kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
It's easy for an Apple engineer to accidentally try to build WebKit from the open-source workspace, rather than an internal workspace which contains extra bits needed to compile WebKit successfully on internal SDKs. The failure mode is pretty cryptic: builds usually fail with missing symbols during linking, etc.
Let's check for this condition before building, so build-webkit or Make can fail early with a useful message.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/99415058>
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/3901
EWS
Committed 254059@main (d398a88b431e): <https://commits.webkit.org/254059@main>
Reviewed commits have been landed. Closing PR #3901 and removing active labels.
EWS
Committed 254064@main (1c3a52cd871e): <https://commits.webkit.org/254064@main>
Reviewed commits have been landed. Closing PR #3927 and removing active labels.
Elliott Williams
Reverted by https://github.com/WebKit/WebKit/pull/3938
EWS
Committed 254083@main (3f0eab0693e7): <https://commits.webkit.org/254083@main>
Reviewed commits have been landed. Closing PR #3938 and removing active labels.
Elliott Williams
Reverted because this change was breaking builds when a Makefile sets WORKSPACE_PATH.
Elliott Williams
Another thing we could do here, once this is functional, is to have webkitdirs.pm change its default workspace to the internal one when the SDK ends in ".internal".