Bug 244492

Summary: REGRESSION (253762@main): [ macOS wk1 Debug ] inspector/runtime/getDisplayableProperties.html is a flaky crash
Product: WebKit Reporter: Karl Rackler <rackler>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: sihui_liu, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210776
Attachments:
Description Flags
test list
none
symbolicated log none

Karl Rackler
Reported 2022-08-29 05:17:21 PDT
Description: inspector/runtime/getDisplayableProperties.html The first failure I saw on the dashboard was on 8/24/2022 at 253764@main. The regression happened in the 253746@main-253797@main range, but I could not repro 253762@main; due to the lack of spades in that range. Commit 253762@main modified the way StorageNamespace is handled, which appears to have introduced the flaky crash. REPRODUCTION STEPS I can reproduce this on 253797@main but cannot reproduce it on 253746@main or earlier. Command: run-webkit-tests --debug -1 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry --child-processes 1 --test-list <test list attached> Result: Regressions: Unexpected crashes (1) inspector/runtime/getDisplayableProperties.html [ Crash ] History: https://results.webkit.org/?suite=layout-tests&test=inspector%2Fruntime%2FgetDisplayableProperties.html&platform=mac&style=debug&flavor=wk1&limit=50000 Crash Log: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKitLegacy 0x107030890 WTF::HashTable<WebCore::SecurityOriginData, WTF::KeyValuePair<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > > >, WTF::DefaultHash<WebCore::SecurityOriginData>, WTF::HashMap<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> >, WTF::DefaultHash<WebCore::SecurityOriginData>, WTF::HashTraits<WebCore::SecurityOriginData>, WTF::HashTraits<WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::SecurityOriginData> >::keyCount() const 1 com.apple.WebKitLegacy 0x107030b44 WTF::HashTable<WebCore::SecurityOriginData, WTF::KeyValuePair<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > > >, WTF::DefaultHash<WebCore::SecurityOriginData>, WTF::HashMap<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> >, WTF::DefaultHash<WebCore::SecurityOriginData>, WTF::HashTraits<WebCore::SecurityOriginData>, WTF::HashTraits<WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::SecurityOriginData> >::isEmpty() const 2 com.apple.WebKitLegacy 0x107032ee8 WTF::HashTable<WebCore::SecurityOriginData, WTF::KeyValuePair<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > > >, WTF::DefaultHash<WebCore::SecurityOriginData>, WTF::HashMap<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> >, WTF::DefaultHash<WebCore::SecurityOriginData>, WTF::HashTraits<WebCore::SecurityOriginData>, WTF::HashTraits<WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > >, WTF::HashTableTraits>::KeyValuePairTraits, WTF::HashTraits<WebCore::SecurityOriginData> >::begin() 3 com.apple.WebKitLegacy 0x1070290e8 WTF::HashMap<WebCore::SecurityOriginData, WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> >, WTF::DefaultHash<WebCore::SecurityOriginData>, WTF::HashTraits<WebCore::SecurityOriginData>, WTF::HashTraits<WTF::RefPtr<WebCore::StorageNamespace, WTF::RawPtrTraits<WebCore::StorageNamespace>, WTF::DefaultRefDerefTraits<WebCore::StorageNamespace> > >, WTF::HashTableTraits>::begin() 4 com.apple.WebKitLegacy 0x107028e60 WebKit::WebStorageNamespaceProvider::copySessionStorageNamespace(WebCore::Page&, WebCore::Page&) 5 com.apple.WebCore 0x126888710 WebCore::Chrome::createWindow(WebCore::Frame&, WebCore::WindowFeatures const&, WebCore::NavigationAction const&) const
Attachments
test list (363 bytes, text/plain)
2022-08-29 05:21 PDT, Karl Rackler 		no flags
Details
symbolicated log (114.06 KB, text/plain)
2022-08-29 05:22 PDT, Karl Rackler 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-08-29 05:17:48 PDT
<rdar://problem/99272856>
Karl Rackler
Comment 2 2022-08-29 05:21:53 PDT
Created attachment 461972 [details] test list
Karl Rackler
Comment 3 2022-08-29 05:22:37 PDT
Created attachment 461973 [details] symbolicated log
Karl Rackler
Comment 4 2022-08-29 05:38:00 PDT
I have marked this test as a flaky crash while this issue is investigated.
EWS
Comment 5 2022-08-29 05:44:02 PDT
Test gardening commit 253901@main (5ddec8e6cd71): <https://commits.webkit.org/253901@main> Reviewed commits have been landed. Closing PR #3769 and removing active labels.
Karl Rackler
Comment 6 2022-08-29 10:35:37 PDT
[Update] I was able to download cached spades from the bots. This allowed me to reproduce the issue more precisely. I can reproduce this on 253762@main but cannot reproduce it on 253761@main or earlier.
Alexey Proskuryakov
Comment 7 2022-08-29 17:25:03 PDT
*** This bug has been marked as a duplicate of bug 244516 ***
Note You need to log in before you can comment on or make changes to this bug.