Bug 244301

Summary:	Web Inspector: Screenshots timeline is unsupported in WebKitLegacy, we should disable it when inspect such targets
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	New Bugs	Assignee:	Patrick Angle <pangle>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	anjalik_22, hi, pangle, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Karl Rackler

Reported 2022-08-24 11:29:50 PDT

Description: inspector/timeline/timeline-event-screenshots.html This test is consistently failing on macOS wk1 since being added at 250535@main. REPRODUCTION STEPS I can reproduce this 253720@main ToT. Command: run-webkit-tests -1 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry inspector/timeline/timeline-event-screenshots.html Result: Regressions: Unexpected text-only failures (1) inspector/timeline/timeline-event-screenshots.html [ Failure ] History: https://results.webkit.org/?suite=layout-tests&test=inspector%2Ftimeline%2Ftimeline-event-screenshots.html&flavor=wk1&limit=50000 Diff: --- /Volumes/Data/worker/Apple-Monterey-Release-WK1-Tests/build/layout-test-results/inspector/timeline/timeline-event-screenshots-expected.txt +++ /Volumes/Data/worker/Apple-Monterey-Release-WK1-Tests/build/layout-test-results/inspector/timeline/timeline-event-screenshots-actual.txt @@ -1,4 +1,3 @@ -CONSOLE MESSAGE: Viewport Tests 'Screenshot' Timeline event records. @@ -6,10 +5,5 @@ -- Running test case: TimelineEvent.FireScreenshots.requestScreenshots Starting Capture... Evaluating... -Stopping Capture... -PASS: Should have at least 1 Screenshot record. -PASS: Screenshot record should contain image data. -Adding screenshot from console... -PASS: Should have added another Screenshot record. -PASS: Screenshot record from console should contain image data. +!! TIMEOUT: took longer than 10000ms

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-08-24 11:30:32 PDT

<rdar://problem/99094864>

Karl Rackler

Comment 2 2022-08-24 11:42:30 PDT

I have marked this test as a consistent failure while this issue is investigated.

EWS

Comment 3 2022-08-24 11:49:52 PDT

Test gardening commit 253735@main (105bd2d6f893): <https://commits.webkit.org/253735@main> Reviewed commits have been landed. Closing PR #3619 and removing active labels.

Patrick Angle

Comment 4 2023-01-24 14:01:54 PST

Pull request: https://github.com/WebKit/WebKit/pull/9073

EWS

Comment 5 2023-01-24 18:15:56 PST

Committed 259326@main (2129556ec693): <https://commits.webkit.org/259326@main> Reviewed commits have been landed. Closing PR #9073 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.