Bug 24425

Summary: Unify JSC/V8 History.idl
Product: WebKit Reporter: Mike Belshe <mbelshe>
Component: WebCore JavaScriptAssignee: Mike Belshe <mbelshe>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch eric: review+

Description Mike Belshe 2009-03-06 09:32:10 PST 
There is no difference in functionality between JSC and V8.

These IDL attributes enforce proper cross-domain security checking for the History object.  JSC implements this as part of its CustomGetOwnPropertySlot; v8 does this by using CheckDomainSecurity, allowing access specifically to back(), forward(), and go().

Both pass the layout tests.
Comment 1 Mike Belshe 2009-03-06 09:34:40 PST 
Created attachment 28364 [details]
patch
Comment 2 Eric Seidel (no email) 2009-03-06 10:30:58 PST 
Comment on attachment 28364 [details]
patch

Looks good to me.  Sam should see this pass by, but I expect he agrees with me. :)
Comment 3 Eric Seidel (no email) 2009-03-09 12:48:41 PDT 
	M	WebCore/ChangeLog
	M	WebCore/page/History.idl
Committed r41534