Bug 244147

Summary:	An error creating a PR can result in commit message loss
Product:	WebKit	Reporter:	Simon Fraser (smfr) <simon.fraser>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	ap, jbedard, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	239082

Description Simon Fraser (smfr) 2022-08-19 16:21:20 PDT

I just lost 15 minutes of typing because of the following:

1. With stages changes, did `git webkit pr --no-update --issue NNNN`
2. While the commit log editor (TextMate) was still open, did a Ctrl-C in terminal because I need to fix a style error.
3. Quit TextMate, assuming the long commit message I'd just written would get saved.
4. Did `git webkit pr --no-update --issue NNNN` again
5. Got an error about already being on the branch
6. Did `git webkit pr --no-update`
7. It launched TextMate with a fresh commit message, which didn't even contain the bugzilla link

Comment 1 Radar WebKit Bug Importer 2022-08-19 16:27:45 PDT

<rdar://problem/98903871>

Comment 2 Simon Fraser (smfr) 2022-08-31 16:08:10 PDT

Simpler steps:
1. Have local changes
2. `git webkit pr --issue NNN`
3. git makes a PR branch
4. Type a long commit message and save the file
5. Decide you want to change something, Ctrl-C the `git webkit pr`

Now you're on a branch with no commits. If you try to repeat the `git webkit pr --issue NNNN` you get an error:

OpenSource % git webkit pr --no-update --issue 68196      
Creating a pull-request for '68196' but we're on 'eng/border-radius-clipping-of-composited-layers-doesnt-work'

so you use `git webkit pr`, and it throws up a commit message editor with a fresh, empty commit message, without even the bug number.