Bug 24411 – [GTK] Text manipulation undo not working

• Component: New Bugs
• Status: UNCONFIRMED

[jasneet]

I Steps:
1.Go to http://www.networkedmediatank.com/showthread.php?tid=13161&page=last
2.Create an account
3.Go to quick reply section
4.Add some text, select a part of text
5.Press CTRL-X
6.Press CTRL-Z

II Issue: 
Selected part doesn't appear after Ctrl + Z

III Other Browsers:
FF3: OK
IE7: OK 

IV Nightly tested: 41443

Bug in Chromium : http://code.google.com/p/chromium/issues/detail?id=7148

[Pacho Ramos]

The same occurs with webkit-gtk-1.1.11 under linux

[Seulgi Kim]

I confirmed Gtk WebKit2 on r142157 don't save undoStack since this uses EmptyEditorClient.
Must using EditorClient in WebKit1 or creating new EditorClient for WebKit2.

[Seulgi Kim]

Created attachment 187194 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[WebKit Review Bot]

Attachment 187194 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp', u'Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.messages.in', u'Source/WebKit2/WebProcess/WebPage/gtk/WebPageGtk.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:13:  Line contains tab character.  [whitespace/tab] [5]
WARNING: File exempt from style guide. Skipping: "Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h"
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Seulgi Kim]

Now I just implement CoreIPC messages to send command. I'll do remains soon.
If there is something wrong, please comment.

[Martin Robinson]

So we already have webkit_web_view_can_execute_editing_command, which looks like it encompasses all of these. Or am I mistaken?

[Seulgi Kim]

Created attachment 187222 [details]
Patch

[Seulgi Kim]

(In reply to comment #7)
> So we already have webkit_web_view_can_execute_editing_command, which looks like it encompasses all of these. Or am I mistaken?

You're right. There already exists function to do.
But I think the function name is webkit_web_view_execute_editing_command, instead of webkit_web_view_can_execute_editing_command

[Seulgi Kim]

Created attachment 187224 [details]
Patch

[Seulgi Kim]

(In reply to comment #10)
> Created an attachment (id=187224) [details]
> Patch

I confirmed that clipboard command messages are sent properly. Fix to bind only undo and redo signals.

[Martin Robinson]

Comment on attachment 187224 [details]
Patch

Hrm. So is the issue that Ctrl+Z isn't causing undo to happen? I wonder if this should be hooked in at a different place. Check out webkit_web_view_real_undo from WebKit1. Do we need something like that?