| Summary: | AX: AccessibilityObject does not always update its m_lastKnownIsIgnoredValue which can result in missing calls to AXObjectCache::childrenChanged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tyler Wilcock
2022-08-17 17:23:42 PDT
Created attachment 461703 [details]
Patch
Created attachment 461713 [details]
Patch
Comment on attachment 461713 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461713&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:3804 > + if (cache should we should return immediately if !cache (In reply to chris fleizach from comment #4) > Comment on attachment 461713 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461713&action=review > > > Source/WebCore/accessibility/AccessibilityObject.cpp:3804 > > + if (cache > > should we should return immediately if !cache I don't think so, since we'll still want to computeAccessibilityIsIgnored and return that result to the caller (which is not dependent on the cache). Committed 253598@main (45a88c53617c): <https://commits.webkit.org/253598@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461713 [details]. |