Bug 244068
| Summary: | Network process should check firstPartyForCookies is an expected URL | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> |
| Component: | WebKit Process Model | Assignee: | Alex Christensen <achristensen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, Hironori.Fujii, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 244315 | ||
| Bug Blocks: | |||
Alex Christensen
More IPC hardening
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alex Christensen
Pull request: https://github.com/WebKit/WebKit/pull/3434
EWS
Committed 253715@main (c2af5021ad07): <https://commits.webkit.org/253715@main>
Reviewed commits have been landed. Closing PR #3434 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/99063901>
WebKit Commit Bot
Re-opened since this is blocked by bug 244315
Alex Christensen
This also broke imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html
Alex Christensen
Pull request: https://github.com/WebKit/WebKit/pull/5225
EWS
Committed 255420@main (361f64fcdd4b): <https://commits.webkit.org/255420@main>
Reviewed commits have been landed. Closing PR #5225 and removing active labels.
Fujii Hironori
It's been reported the assertion added by this change is failing.
Bug 246858 – [SOUP] http/tests/security/cookies/cookie-theft-with-javascript-doc.html crashing
Bug 247658 – [WinCairo] ASSERTION FAILED: result in WebKit::NetworkProcess::allowsFirstPartyForCookies
darinadler added a comment.
https://github.com/WebKit/WebKit/commit/361f64fcdd4b6aa17aaafcc55ebc88ab89acfc89#r87636633
> Why is this assertion correct? I am hitting this assertion while running run-webkit-tests and it’s really slowing down my testing.
Fujii Hironori
One more.
Bug 248065 – REGRESSION(?): [iOS] ASSERTION FAILED: result in WebKit::NetworkProcess::allowsFirstPartyForCookies()