Bug 244020
| Summary: | use enum values for tag and element names | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> |
| Component: | DOM | Assignee: | Cameron McCormack (:heycam) <heycam> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Cameron McCormack (:heycam)
We currently generate the WebCore::findHTMLTag function and use this in the AtomHTMLToken constructor. We can extend this to look for any known tag name (HTML, SVG, or MathML) by reworking make-names.pl a bit.
This isn't helpful for Speedometer performance, since parsing non-HTML tags is rare, but local testing shows it to be a neutral change. Handling all known tag names will set the stage for a later patch that does improve Speedometer performance.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/98767683>
Cameron McCormack (:heycam)
Pull request: https://github.com/WebKit/WebKit/pull/3395
Cameron McCormack (:heycam)
Broadening the scope of this bug to introduce enums for known tag names, element names, and namespaces, and to use the enums in the HTML parser instead of checking for QualifiedName equality in many places.
Local testing shows this could be a ~1% improvement on Speedometer 2.1.
Cameron McCormack (:heycam)
Pull request: https://github.com/WebKit/WebKit/pull/3689
EWS
Committed 254007@main (321c28bff9f2): <https://commits.webkit.org/254007@main>
Reviewed commits have been landed. Closing PR #3689 and removing active labels.