Bug 243983
Summary: | [GTK][WPE] Improve the application icon passed to notification service | ||
---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> |
Component: | WebKitGTK | Assignee: | Carlos Garcia Campos <cgarcia> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bugs-noreply |
Priority: | P2 | Keywords: | Gtk |
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Carlos Garcia Campos
We currently check if the app icon is in the gtk theme to send the name. That only works for GTK and apps having an icon in the theme. We can also check if the application has a desktop file and get the icon from there.
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Carlos Garcia Campos
Pull request: https://github.com/WebKit/WebKit/pull/3355
EWS
Committed 253464@main (da53f062a9f1): <https://commits.webkit.org/253464@main>
Reviewed commits have been landed. Closing PR #3355 and removing active labels.