Bug 243955
| Summary: | REGRESSION (238684@main, 985de701a): Add back fault logs when WebKit process calls exit() | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | achristensen, cdumez, kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 216594, 226860 | ||
| Bug Blocks: | |||
David Kilzer (:ddkilzer)
Commit 985de701a (238684@main) changed fault logs to error logs for one case when exit() is called, but this makes it impossible to know how often this occurs.
We should change the error logs back to fault logs so we can measure how often this occurs.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/98689492>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/3326
David Kilzer (:ddkilzer)
(In reply to David Kilzer (:ddkilzer) from comment #2)
> Pull request: https://github.com/WebKit/WebKit/pull/3326
Going to withdraw the PR here as it's going to cause issues with testers again.
David Kilzer (:ddkilzer)
(In reply to David Kilzer (:ddkilzer) from comment #3)
> (In reply to David Kilzer (:ddkilzer) from comment #2)
> > Pull request: https://github.com/WebKit/WebKit/pull/3326
>
> Going to withdraw the PR here as it's going to cause issues with testers
> again.
Oops, I was looking at a different radar that claimed the fault logs caused test failures, but there were no changes made for that radar, so I'm proceeding with the fix.
EWS
Committed 253479@main (5738533dfc4f): <https://commits.webkit.org/253479@main>
Reviewed commits have been landed. Closing PR #3326 and removing active labels.