Bug 243927

Summary: WebAccessibilityObjectWrapperBase m_isolatedObject and m_axObject should have stronger types than AXCoreObject
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tyler Wilcock
Reported 2022-08-14 10:48:20 PDT
These member variables are clearly intended to contain a live object (AccessibilityObject) and isolated object (AXIsolatedObject) respectively, and they should be typed as such so we can avoid accidentally assigning the wrong object to each variable. This also makes future refactors easier (e.g. https://bugs.webkit.org/show_bug.cgi?id=243920) reducing the amount of casting required.
Attachments
Patch (10.37 KB, patch)
2022-08-14 10:52 PDT, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-08-14 10:48:30 PDT
<rdar://problem/98641827>
Tyler Wilcock
Comment 2 2022-08-14 10:52:12 PDT
Created attachment 461621 [details] Patch
EWS
Comment 3 2022-08-14 16:02:01 PDT
Committed 253413@main (675f5f8225a9): <https://commits.webkit.org/253413@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461621 [details].
Note You need to log in before you can comment on or make changes to this bug.