Bug 243716
| Summary: | Web Inspector: Debugger: symbolic breakpoints should work with native functions | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> |
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | commit-queue, inspector-bugzilla-changes, webkit-bug-importer, ysuzuki |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=244503 | ||
| Bug Depends on: | 142914, 244435 | ||
| Bug Blocks: | 243994 | ||
Devin Rousso
e.g. a symbolic breakpoint for "preventDefault" should pause when `Event.prototype.preventDefault` is called
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/98705760>
Devin Rousso
Pull request: https://github.com/WebKit/WebKit/pull/3367
EWS
Committed 253791@main (bdc7d2c65ad3): <https://commits.webkit.org/253791@main>
Reviewed commits have been landed. Closing PR #3367 and removing active labels.
WebKit Commit Bot
Re-opened since this is blocked by bug 244435
Yusuke Suzuki
Debugger destruction caused crash. Can you take a look?
Also, why is debugger enabled in these workers? Can you check it is not enabled in the normal browsing? We are generating slow code if debugger exists, and it is not OK to always use this slow code, so let’s check it.
Also, JetStream2 and Speedometer2 tests are frequently crashing in the large revision range and this is included in that range. So we need to validate this will not cause JetStream2 and Speedometer2 crashes.
Yusuke Suzuki
Confirmed, JetStream2 gets broken with this. So, when updating, please ensure that JetStream2 runs correctly.
Devin Rousso
Pull request: https://github.com/WebKit/WebKit/pull/3831
EWS
Committed 253999@main (f0c85afe24ed): <https://commits.webkit.org/253999@main>
Reviewed commits have been landed. Closing PR #3831 and removing active labels.