Bug 243708
| Summary: | run-webkit-tests --leaks is broken again | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> |
| Component: | Tools / Tests | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
David Kilzer (:ddkilzer)
run-webkit-tests --leaks is broken again.
TypeError raised: cannot use a bytes pattern on a string-like object
Traceback (most recent call last):
File "WebKit.github/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 92, in main
run_details = run(port, options, args, stderr)
File "WebKit.github/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 491, in run
run_details = manager.run(args)
File "WebKit.github/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 407, in run
if not self._set_up_run(test_inputs, device_type=device_type):
File "WebKit.github/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 310, in _set_up_run
self._port.setup_test_run(device_type)
File "WebKit.github/Tools/Scripts/webkitpy/port/mac.py", line 337, in setup_test_run
warmup_driver.run_test(DriverInput('file:///warmup-does-not-exist', 60000., None, should_run_pixel_test=False), stop_when_done=True)
File "WebKit.github/Tools/Scripts/webkitpy/port/driver.py", line 846, in run_test
return self._driver.run_test(driver_input, stop_when_done)
File "WebKit.github/Tools/Scripts/webkitpy/port/driver.py", line 243, in run_test
self.do_post_tests_work()
File "WebKit.github/Tools/Scripts/webkitpy/port/driver.py", line 282, in do_post_tests_work
self._server_process.set_child_processes(self._parse_child_processes_output(block.decoded_content))
File "WebKit.github/Tools/Scripts/webkitpy/port/driver.py", line 301, in _parse_child_processes_output
m = re.match(b'^([^:]+): ([0-9]+)$', line)
File "/AppleInternal/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/re.py", line 191, in match
return _compile(pattern, flags).match(string)
TypeError: cannot use a bytes pattern on a string-like object
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/98356055>
David Kilzer (:ddkilzer)
Pull request: https://github.com/WebKit/WebKit/pull/3132
David Kilzer (:ddkilzer)
This patch also fixes these warning messages by removing the environment variable:
15:26:18.196 24800 ERROR: invalid option: JSC_usePoisoning=0
15:26:18.197 24800 ERROR: invalid option: JSC_usePoisoning=0
15:26:18.197 24800 ERROR: invalid option: JSC_usePoisoning=0
15:26:18.197 24800 ERROR: invalid option: JSC_usePoisoning=0
EWS
Committed 253268@main (5940cd0f7f9a): <https://commits.webkit.org/253268@main>
Reviewed commits have been landed. Closing PR #3132 and removing active labels.